Tsaucer/prepare tpch examples for ci #710
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cacefab.
…ker and also run unit tests
|
|
||
| - name: Run TPC-H examples | ||
| run: | | ||
| cd examples/tpch |
There was a problem hiding this comment.
I think the first line here should activate the venv
- name: Run TPC-H examples
run: |
source venv/bin/activate
cd examples/tpch
python convert_data_to_parquet.py
pytest _tests.py
There was a problem hiding this comment.
Thanks. I hadn't looked at how far it got before I had to step away for the day. I know I also need to add in the upload and download artifacts between stages.
…different containers
… we can just code the version of the data generator instead
|
It looks like CI is running correctly and also caching the data. I’ll rebase in the morning and get the PR ready to merge. |
|
Closing in favor of #711 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #696.
Rationale for this change
This PR sets up a work flow to generate TPH-C 1Gb data set in CI, runs the 22 examples, and compares their results to the
known answer file. By adding this PR we improve the robustness of our test suite.
What changes are included in this PR?
This PR adds the following changes:
substringoperation that was missing. Sometime between 36.0.0 and 38.0.0substrwas performing the operation instead.Are there any user-facing changes?
substringfunction is exposed in python.