Skip to content

[BrushGraph 7/7] Integrate Brush Graph into the app#66

Open
maxmmitchell wants to merge 2 commits intobrush-graph/6-canvasfrom
brush-graph/7-integration
Open

[BrushGraph 7/7] Integrate Brush Graph into the app#66
maxmmitchell wants to merge 2 commits intobrush-graph/6-canvasfrom
brush-graph/7-integration

Conversation

@maxmmitchell
Copy link
Copy Markdown

@maxmmitchell maxmmitchell commented Apr 27, 2026

Description

This is the final PR in the Brush Graph stack. It ties all the components together and integrates the feature into the main application navigation and resource files.

Details

  • Navigation routes and menu configurations.
  • Mapping Proto enums to localized string resources at the edge of the UI (in DisplayTextExtensions).
  • Adding the Brush Graph Studio to the existing CahierNavGraph, as a default-on toggle which controls whether the "Launch" button next to Brush Designer leads to tab-based or graph-based view.
  • Action menu and FAB/SpeedDial for key actions.
  • Notification pane for viewing errors in the UI.
  • Tutorial UI elements for displaying the tutorial text to the user.
  • Brush graph entry point from Cahier notes ("Edit active brush")
  • Some misc. cleanup of code.

Dependencies

  • Target: brush-graph/6-canvas

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive "Brush Graph" feature, a node-based visual designer for ink brushes. It includes a new navigation destination, a complex UI with canvas, inspector, and notification panes, and a tutorial system. Key technical changes include the addition of an ExtendedColorScheme for warning states, Hilt injection for the texture store, and autosave functionality in the drawing canvas. Review feedback highlights critical issues with texture serialization due to incorrect store instantiation, potential UI freezes from blocking I/O on the main thread, and opportunities for code cleanup regarding unused parameters and magic strings.

Comment thread app/src/main/java/com/example/cahier/developer/brushgraph/ui/BrushGraphScreen.kt Outdated
Comment thread app/src/main/java/com/example/cahier/developer/brushgraph/ui/BrushGraphScreen.kt Outdated
Comment thread app/src/main/java/com/example/cahier/core/navigation/CahierNavGraph.kt Outdated
Comment thread app/src/main/java/com/example/cahier/developer/brushgraph/ui/BrushGraphContent.kt Outdated
@maxmmitchell maxmmitchell force-pushed the brush-graph/7-integration branch 3 times, most recently from b5d3f01 to feb8bd6 Compare April 27, 2026 13:15
@maxmmitchell maxmmitchell force-pushed the brush-graph/6-canvas branch from bcf7952 to 53d3ee1 Compare April 27, 2026 13:22
@maxmmitchell maxmmitchell force-pushed the brush-graph/7-integration branch from feb8bd6 to d599cde Compare April 27, 2026 21:57
@maxmmitchell maxmmitchell force-pushed the brush-graph/6-canvas branch 2 times, most recently from 5bc8df0 to 261113b Compare April 28, 2026 07:37
@maxmmitchell maxmmitchell force-pushed the brush-graph/7-integration branch from d599cde to b512362 Compare April 28, 2026 07:56
@maxmmitchell maxmmitchell marked this pull request as ready for review April 28, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant