Gemini review comments

Author: maxmmitchell

app/src/main/java/com/example/cahier/developer/brushgraph/data/GraphDataModel.kt

@@ -395,7 +395,11 @@ sealed class Port(
 ) {
     abstract val side: PortSide
 
-    class Output(nodeId: String, id: String = "output", label: DisplayText? = null) : 
+    companion object {
+        const val OUTPUT_PORT_ID = "output"
+    }
+
+    class Output(nodeId: String, id: String = OUTPUT_PORT_ID, label: DisplayText? = null) : 
         Port(nodeId, id, label, isAddPort = false) {
         override val side = PortSide.OUTPUT
     }

app/src/main/java/com/example/cahier/developer/brushgraph/ui/GraphCameraController.kt

@@ -33,6 +33,8 @@ import com.example.cahier.developer.brushgraph.data.TutorialAnchor
 import com.example.cahier.developer.brushgraph.data.TutorialStep
 import com.example.cahier.developer.brushgraph.ui.node.NodeRegistry
 
+private const val TUTORIAL_TARGET_Y = 280f
+
 @Composable
 fun GraphCameraController(
   offset: Offset,
@@ -58,7 +60,7 @@ fun GraphCameraController(
       val node = step.getTargetNode(graph)
       if (node != null) {
         val density = context.resources.displayMetrics.density
-        val targetY = 280f * density
+        val targetY = TUTORIAL_TARGET_Y * density
         val targetX = maxWidthDp.value * density / 2f
 
         val newOffset = calculateFocusOffset(

app/src/main/java/com/example/cahier/developer/brushgraph/ui/GraphCanvas.kt

@@ -78,6 +78,7 @@ import com.example.cahier.developer.brushgraph.data.GraphEdge
 import com.example.cahier.developer.brushgraph.data.GraphNode
 import com.example.cahier.developer.brushgraph.data.NodeData
 import com.example.cahier.developer.brushgraph.data.Port
+import com.example.cahier.developer.brushgraph.data.Port.OUTPUT_PORT_ID
 import com.example.cahier.developer.brushgraph.data.PortSide
 import kotlin.math.roundToInt
 
@@ -170,7 +171,7 @@ fun GraphCanvas(
                     val toNode = currentGraph.nodes.find { it.id == edge.toNodeId }
 
                     val start = if (fromNode != null) {
-                        nodeRegistry.getPortPosition(edge.fromNodeId, "output", currentGraph)
+                        nodeRegistry.getPortPosition(edge.fromNodeId, OUTPUT_PORT_ID, currentGraph)
                     } else Offset.Zero
                     val end = if (toNode != null) {
                         nodeRegistry.getPortPosition(edge.toNodeId, edge.toPortId, currentGraph)
@@ -263,7 +264,7 @@ fun GraphCanvas(
                         val edge = graph.edges.find { it.toNodeId == node.id && it.toPortId == portId && !it.isDisabled }
 
                         if (edge != null) {
-                          activeSourcePort = Port.Output(edge.fromNodeId, "output")
+                          activeSourcePort = Port.Output(edge.fromNodeId)
                           onEdgeDetach(edge)
                         }
                       }
@@ -435,7 +436,7 @@ fun EdgeRenderer(
       val toNode = graph.nodes.find { it.id == edge.toNodeId }
 
       val start = if (fromNode != null) {
-          nodeRegistry.getPortPosition(edge.fromNodeId, "output", graph)
+          nodeRegistry.getPortPosition(edge.fromNodeId, OUTPUT_PORT_ID, graph)
       } else Offset.Zero
       val end = if (toNode != null) {
           nodeRegistry.getPortPosition(edge.toNodeId, edge.toPortId, graph)

app/src/main/java/com/example/cahier/developer/brushgraph/ui/GraphLayout.kt

@@ -20,7 +20,6 @@ import com.example.cahier.developer.brushgraph.data.BrushGraph
 import com.example.cahier.developer.brushgraph.data.GraphNode
 import com.example.cahier.developer.brushgraph.data.NodeData
 import com.example.cahier.developer.brushgraph.data.Port
-import java.util.UUID
 
 const val NODE_WIDTH = 300f
 const val NODE_PADDING_VERTICAL = 8f
@@ -180,6 +179,7 @@ object GraphLayout {
     nodeSubtreeMaxY: MutableMap<String, Float>
   ): Float {
     val node = graph.nodes.find { it.id == nodeId } ?: return desiredY
+    if (depth > 100) return desiredY // Prevent stack overflow on extremely deep graphs
     val data = node.data as? NodeData.Behavior ?: return desiredY
 
     if (assignedNodeIds.contains(nodeId)) {