feat(product tours): support auto-launch field, reduce bundle size #2724
+134
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset (and the release label) is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
17 tasks
adboio
changed the base branch from
12-10-feat_product_tours_support_modal_steps
to
graphite-base/2724
Contributor
Contributor
|
Size Change: 0 B Total Size: 5.19 MB ℹ️ View Unchanged
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| "hls.js": "^1.5.15", | ||
| "next": "^15.5.7", | ||
| "posthog-js": "*", | ||
| "posthog-js": "file:/Users/adambowker/posthog-js/target/posthog-js.tgz", |
Contributor
There was a problem hiding this comment.
syntax: hardcoded local file path should not be committed
Suggested change
| "posthog-js": "file:/Users/adambowker/posthog-js/target/posthog-js.tgz", | |
| "posthog-js": "*", |
Prompt To Fix With AI
This is a comment left during a code review.
Path: playground/nextjs/package.json
Line: 23:23
Comment:
**syntax:** hardcoded local file path should not be committed
```suggestion
"posthog-js": "*",
```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+193
to
+199
| // Determine the trigger selector - explicit trigger_selector takes precedence, | ||
| // otherwise use conditions.selector for click-only tours (auto_launch=false) | ||
| const triggerSelector = tour.trigger_selector || (!tour.auto_launch ? tour.conditions?.selector : null) | ||
|
|
||
| // Tours with a trigger selector: always attach listener | ||
| // These are "on-demand" tours that show when clicked | ||
| if (tour.trigger_selector) { | ||
| if (triggerSelector) { |
Contributor
There was a problem hiding this comment.
logic: when tour.auto_launch is undefined (not explicitly set), !tour.auto_launch evaluates to true, meaning tours without an explicit auto_launch field will use conditions.selector as a trigger selector. This changes the default behavior for existing tours that don't have the auto_launch field set. Consider checking explicitly for tour.auto_launch === false instead of !tour.auto_launch to preserve backwards compatibility.
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/browser/src/extensions/product-tours/product-tours.tsx
Line: 193:199
Comment:
**logic:** when `tour.auto_launch` is `undefined` (not explicitly set), `!tour.auto_launch` evaluates to `true`, meaning tours without an explicit `auto_launch` field will use `conditions.selector` as a trigger selector. This changes the default behavior for existing tours that don't have the `auto_launch` field set. Consider checking explicitly for `tour.auto_launch === false` instead of `!tour.auto_launch` to preserve backwards compatibility.
How can I resolve this? If you propose a fix, please make it concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file