feat(product tours): support 'modal' steps #2723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
17 tasks
Contributor
Contributor
|
Size Change: -7.57 kB (-0.15%) Total Size: 5.19 MB
ℹ️ View Unchanged
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
playground/nextjs/package.json
Outdated
| "hls.js": "^1.5.15", | ||
| "next": "^15.5.7", | ||
| "posthog-js": "*", | ||
| "posthog-js": "file:/Users/adambowker/posthog-js/target/posthog-js.tgz", |
Contributor
There was a problem hiding this comment.
logic: Local file path reference should not be committed - this breaks the build for other developers.
Suggested change
| "posthog-js": "file:/Users/adambowker/posthog-js/target/posthog-js.tgz", | |
| "posthog-js": "*", |
Prompt To Fix With AI
This is a comment left during a code review.
Path: playground/nextjs/package.json
Line: 23:23
Comment:
**logic:** Local file path reference should not be committed - this breaks the build for other developers.
```suggestion
"posthog-js": "*",
```
How can I resolve this? If you propose a fix, please make it concise.
adboio
force-pushed
the
12-10-feat_product_tours_support_modal_steps
branch
from
1bf7afb to
2b56252
Compare
adboio
force-pushed
the
12-10-feat_product_tours_support_modal_steps
branch
from
2b56252 to
ce72dba
Compare
adboio
force-pushed
the
12-10-feat_product_tours_support_modal_steps
branch
from
ce72dba to
a07da09
Compare
lucasheriques
approved these changes
Dec 10, 2025
Contributor
lucasheriques
left a comment
lucasheriques
left a comment
There was a problem hiding this comment.
good to fix the package.json to not commit your local changes
and also make it so both survreys and product tours share the url matching, since the function is the same
otherwise 🚢
lucasheriques
approved these changes
Dec 10, 2025
Contributor
lucasheriques
left a comment
lucasheriques
left a comment
There was a problem hiding this comment.
mostly nice to have, prob can get those down in 1 session with claude, but approving already so we can demo 🚢
|
|
||
| // Modal step (no selector) - render without a target element | ||
| if (!step.selector) { | ||
| this._captureEvent('product tour step shown', { |
Contributor
There was a problem hiding this comment.
good to have the events as constants in an enum, similar to how we do it for surveys
| const window = _window as Window & typeof globalThis | ||
|
|
||
| // Tour condition checking utilities (moved from utils/product-tour-utils.ts) | ||
| function doesTourUrlMatch(tour: ProductTour): boolean { |
Contributor
There was a problem hiding this comment.
share this utility with surveys or use the surveys, as it's the same really
maybe we just pass the url and the target so not pass the entire product tour
| } | ||
| } | ||
|
|
||
| function doesTourSelectorMatch(tour: ProductTour): boolean { |
Contributor
There was a problem hiding this comment.
survey also has a selector filter that we can prob reuse
| } | ||
| } | ||
|
|
||
| function isTourInDateRange(tour: ProductTour): boolean { |
Contributor
There was a problem hiding this comment.
again can also share this with surveys 🤣 since exact same names too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file