feat: For iOS add support for downloading files with blob or base64 URLs #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I don't have a good idea how to test this integration 🤔. Please let me know if you have any ideas |
Tyschenko
changed the title
7 tasks
smilingkylan
added a commit
that referenced
this pull request
Jun 17, 2025
…or_Android feat: For Android add support for downloading files with blob or base64 URLs #50
smilingkylan
approved these changes
Jun 17, 2025
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the first time this issue was raised in 2021 MetaMask/metamask-mobile#2195
On both platforms downloading of URLs with blob: prefix (e.g. blob:https://google.com/6c9102b5) or with data: prefix (e.g. data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAfQAAAE) is unsupported.
To test I've used two websites:
When user clicks such link, nothing happens. Below you can find two videos, one for blob: URL and one for data: URL.
https://github.com/user-attachments/assets/47f140f9-9f6d-43e0-a982-c4654ec4478f
https://github.com/user-attachments/assets/81f4ea02-1b11-4106-8346-99a5857ed6dd
In this Pull request I updated iOS WebView integration to handle both URLs. Below you can find videos to prove it. Android support is coming in the next PR tomorrow.
https://github.com/user-attachments/assets/caf9eb8d-b7be-47b9-889d-7ae6c21c08cb
https://github.com/user-attachments/assets/6591cee9-aa35-4ad9-8543-b2a6eada014a