Skip to content

Conversation

@Tyschenko
Copy link
Contributor

Pull request with downloading support - MetaMask/react-native-webview-mm#50

Problem:
When you try to download a blob file, you receive a URL like blob:https://google.com/12345. On iOS it's required to include such URL scheme (blob prefix) into the file Info.plist so the system won't filter out such URLs and client can handle it.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

… Browser we need to include these schemes in Info.plist
@Tyschenko Tyschenko added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform Mobile Platform team No E2E Smoke Needed labels Jun 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 3, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.20%. Comparing base (d84d51b) to head (ed71b73).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16018      +/-   ##
==========================================
+ Coverage   70.13%   70.20%   +0.06%     
==========================================
  Files        2552     2552              
  Lines       54334    54467     +133     
  Branches     8365     8380      +15     
==========================================
+ Hits        38107    38238     +131     
+ Misses      13785    13782       -3     
- Partials     2442     2447       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 3, 2025

@Tyschenko Tyschenko closed this Jun 26, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants