Skip to content

Add row class name for Row component. #26588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
linuspahl wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −2
Open

Add row class name for Row component. #26588

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0927686
Add `row` class name for `Row` component.
linuspahl Jul 6, 2026
b7728a8
Merge branch 'master' into issue-26481/message-details-scroll
linuspahl Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions graylog2-web-interface/src/components/bootstrap/Row.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,11 @@ const StyledRow = styled.div`
}
`;

const Row = ({ children = undefined, as = undefined, ...rest }: Props, ref: React.ForwardedRef<HTMLDivElement>) => (
<StyledRow ref={ref} as={as} {...rest}>
const Row = (
{ children = undefined, as = undefined, className = undefined, ...rest }: Props,
ref: React.ForwardedRef<HTMLDivElement>,
) => (
<StyledRow ref={ref} as={as} className={`${className ?? ''} row`} {...rest}>

@linuspahl linuspahl Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer using styled(Row) over

.row {
  margin-right: 0;
}

or even better adding a prop to the Row component to change its appearance.

But since there are already multiple cases where we apply the styling via the row class, it would require a bigger refactoring.

{children}
</StyledRow>
);
Expand Down
Loading