Add row class name for Row component.#26588
Open
linuspahl wants to merge 1 commit into
Open
Conversation
linuspahl
commented
Jul 6, 2026
| { children = undefined, as = undefined, className = undefined, ...rest }: Props, | ||
| ref: React.ForwardedRef<HTMLDivElement>, | ||
| ) => ( | ||
| <StyledRow ref={ref} as={as} className={`${className ?? ''} row`} {...rest}> |
Contributor
Author
There was a problem hiding this comment.
I personally prefer using styled(Row) over
.row {
margin-right: 0;
}
or even better adding a prop to the Row component to change its appearance.
But since there are already multiple cases where we apply the styling via the row class, it would require a bigger refactoring.
dennisoelkers
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This PR is a follow-up for #26191. It simple adds a CSS class to the
Rowcomponent which has been removed, but is still in use in some cases to style theRowcomponent.For example in the
MessageTableEntrycomponent.Fixes #26481
/nocl - Fixes a small unreleased UI regression