Add no random chargen field. Apply it to GDS

[Maleclypse]

Summary

None

Purpose of change

Fix #85480

Describe the solution

Adjust starting trait to false and valid to true. Not sure how those got set backwards but blame chain is broken so not going to go search.

Describe alternatives you've considered

Testing

Additional context

[akrieger]

Is "valid": true the default? Looks like you just deleted the entire key.

[Maleclypse]

Is "valid": true the default? Looks like you just deleted the entire key.

"valid": false, // Can be mutated ingame (default: true). Note that prerequisites can even mutate invalid mutations.

"starting_trait": true, // Can be selected at character creation (default: false)
So looks like I can delete both lines

[SariusSkelrets]

Setting it as "starting_trait": false will prevent people to start with it. AFAIK the ability to pick it during chargen is intended as part of a challenge that doesn't require a precise scenario, letting it stack with other scenarios.

There should be a bool for a trait that can be picked at start but won't be granted by random starts. This way, it'll solve the issue of being far too harsh for random starts while not removing it from starting options altogether.

[Maleclypse]

Setting it as "starting_trait": false will prevent people to start with it. AFAIK the ability to pick it during chargen is intended as part of a challenge that doesn't require a precise scenario, letting it stack with other scenarios.

There should be a bool for a trait that can be picked at start but won't be granted by random starts. This way, it'll solve the issue of being far too harsh for random starts while not removing it from starting options altogether.

I agree with you but the closest was no random for NPCs and I don't have time to make the no random start json object.

[Maleclypse]

There should be a bool for a trait that can be picked at start but won't be granted by random starts. This way, it'll solve the issue of being far too harsh for random starts while not removing it from starting options altogether.

trait_id Character::random_bad_trait()
{
    return get_random_trait( [this]( const mutation_branch & mb ) {
        return mb.points < 0 && ( mb.chargen_allow_npc || is_avatar() );
    } );
}

and here

bool chargen_allow_npc = true;

and here

optional( jo, was_loaded, "chargen_allow_npc", chargen_allow_npc, true );

would all need to be mirrored or edited. which shouldn't be hard but I really don't have time tonight to make the fix. despite how much I keep thinking 20 minute adventure in and out