Skip to content

Make GenerateMetadata robust to sessions without trials #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

alexpiet
Copy link
Collaborator

@alexpiet alexpiet commented Feb 17, 2025

Pull Request instructions:

  • Please follow the update protocol
  • Answer the questions below in detail. Your responses will be emailed to experimenters.
  • If the experimenters must do anything new, provide detailed step by step instructions on the wiki
  • If computer maintainers need to manually update anything, provide detailed step by step instructions
  • Use markdown syntax in order for your comments to be rendered reliably in the email: "1." instead of "1)", use four spaces for indents.
  • If you use the keyword "skip email" in the title, it will skip the email updates
  • Merges from "develop" into "production_testing" should use the keyword "production merge" in the title for reliable indexing of updates
  • Merges from "production_testing" into "main" should use the keyword "update main"

Describe changes:

  • GenerateMetadata generates an error during habituation sessions. This is because the attribute self.behavior_software isn't created unless trials were generated. This doesn't make sense since the software is being used regardless. I moved the function that creates this attribute outside of the behavior_stream function.

What issues or discussions does this update address?

Describe the expected change in behavior from the perspective of the experimenter

  • none

Describe any manual update steps for task computers

  • none

Was this update tested in 446/447?

  • tested

Does this update impact downstream processing by adding new saved files, or changing their format? If so, have you documented changes?

  • No. The upload manifest won't be generated unless a trial is performed, so habituation sessions will not be uploaded.

@alexpiet
Copy link
Collaborator Author

@XX-Yin @hanhou @micahwoodard This is ready for review

Copy link
Collaborator

@XX-Yin XX-Yin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an update I have made in #1267 and #1265, which has not been merged.

It's good to merge this one.

@alexpiet alexpiet merged commit a8f0836 into develop Feb 17, 2025
@alexpiet alexpiet deleted the fix_error_tracking_9 branch March 26, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants