-
Notifications
You must be signed in to change notification settings - Fork 2
add openephys tag to models #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There might be one or two things that need to be updated. I can push the updates. |
Will need to pull in #240 and re-test when that's merged, as it has potentially conflicting changes. In the meantime, The behavior table produced looks like follows; I'm not quite sure if its right... |
…tadata-mapper into openephys_patch
…thub.com/AllenNeuralDynamics/aind-metadata-mapper into enhancement/passive_ophys_behavior_block
…pty parameter sets, and prevent parameter sets with more than 1000 unique values
This should be nearly ready to merge but three questions:
|
|
I added the doc string for that missing func :) |
Checking in on this, is this still being worked on @rcpeene @Ahad-Allen ? |
Yes, sorry for this getting out of scope: we found two huge bugs in the stim table generation code that needed to be fixed that affect all behavior sessions. I am updating the test cases for this today and then we should be done :) |
The changes are minimal. Let me know if anything else needs to be done :)