Skip to content

add openephys tag to models #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 49 commits into
base: dev
Choose a base branch
from
Open

add openephys tag to models #237

wants to merge 49 commits into from

Conversation

rcpeene
Copy link
Collaborator

@rcpeene rcpeene commented Jan 29, 2025

The changes are minimal. Let me know if anything else needs to be done :)

@jtyoung84
Copy link
Contributor

There might be one or two things that need to be updated. I can push the updates.

@rcpeene
Copy link
Collaborator Author

rcpeene commented Jan 31, 2025

Will need to pull in #240 and re-test when that's merged, as it has potentially conflicting changes.

In the meantime,
could @arielleleon or @Ahad-Allen review this?

The behavior table produced looks like follows; I'm not quite sure if its right...
1416080419_752311_20250123_stim_epochs.csv

@rcpeene rcpeene mentioned this pull request Apr 23, 2025
@rcpeene
Copy link
Collaborator Author

rcpeene commented Apr 23, 2025

This should be nearly ready to merge but three questions:

  • @jtyoung84 previously said he had work to do on integrating this Etl. I don't recall the details, has this been addressed?
  • The linter is showing two methods are 'too complex' but I can't conceive of any reasonable way to break them up. What to do about this?
  • One method is missing a docstring. src\aind_metadata_mapper\open_ephys\utils\behavior_utils.py: remove_short_sandwiched_spontaneous. @Ahad-Allen are you able to document this?

@jtyoung84
Copy link
Contributor

This should be nearly ready to merge but three questions:

  • @jtyoung84 previously said he had work to do on integrating this Etl. I don't recall the details, has this been addressed?
  • The linter is showing two methods are 'too complex' but I can't conceive of any reasonable way to break them up. What to do about this?
  • One method is missing a docstring. src\aind_metadata_mapper\open_ephys\utils\behavior_utils.py: remove_short_sandwiched_spontaneous. @Ahad-Allen are you able to document this?
  • We're moving towards having people generate the session.json files locally, but it shouldn't be too difficult to have it run in the transfer service once you are finished.
  • I'd recommend breaking up very long functions or deeply nested functions into smaller methods. As a temporary workaround, you can annotate the methods with # noqa: C901 to skip that check, but please open a tech-debt ticket to re-organize it later.

@Ahad-Allen
Copy link
Contributor

I added the doc string for that missing func :)

@mekhlakapoor
Copy link
Collaborator

Checking in on this, is this still being worked on @rcpeene @Ahad-Allen ?

@Ahad-Allen
Copy link
Contributor

Checking in on this, is this still being worked on @rcpeene @Ahad-Allen ?

Yes, sorry for this getting out of scope: we found two huge bugs in the stim table generation code that needed to be fixed that affect all behavior sessions. I am updating the test cases for this today and then we should be done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants