Skip to content

add openephys tag to models #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 53 commits into from
Jun 3, 2025
Merged

add openephys tag to models #237

merged 53 commits into from
Jun 3, 2025

Conversation

rcpeene
Copy link
Collaborator

@rcpeene rcpeene commented Jan 29, 2025

The changes are minimal. Let me know if anything else needs to be done :)

@jtyoung84
Copy link
Contributor

There might be one or two things that need to be updated. I can push the updates.

@rcpeene
Copy link
Collaborator Author

rcpeene commented Jan 31, 2025

Will need to pull in #240 and re-test when that's merged, as it has potentially conflicting changes.

In the meantime,
could @arielleleon or @Ahad-Allen review this?

The behavior table produced looks like follows; I'm not quite sure if its right...
1416080419_752311_20250123_stim_epochs.csv

@rcpeene rcpeene mentioned this pull request Apr 23, 2025
@mekhlakapoor
Copy link
Collaborator

Checking in on this, is this still being worked on @rcpeene @Ahad-Allen ?

@Ahad-Allen
Copy link
Contributor

Checking in on this, is this still being worked on @rcpeene @Ahad-Allen ?

Yes, sorry for this getting out of scope: we found two huge bugs in the stim table generation code that needed to be fixed that affect all behavior sessions. I am updating the test cases for this today and then we should be done :)

self.recording_dir = npc_ephys.get_single_oebin_path(
self.session_path
).parent
# sessions_root = Path(self.job_settings.sessions_root)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this code isnt being used, you can probably just remove it

@mekhlakapoor mekhlakapoor merged commit b7ba114 into dev Jun 3, 2025
3 checks passed
@mekhlakapoor mekhlakapoor deleted the openephys_patch branch June 3, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants