feat: adds user authentication #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helen-m-lin
requested changes
Feb 26, 2025
| @@ -49,7 +49,8 @@ | |||
| <a href="/job_params">Job Parameters</a> | | |||
| <a title="Download job template as .xslx" href= "/api/job_upload_template" download>Job Submit Template</a> | | |||
| <a title="List of project names" href= "{{ project_names_url }}" target="_blank" >Project Names</a> | | |||
| <a title="For more information click here" href="https://aind-data-transfer-service.readthedocs.io" target="_blank" >Help</a> | |||
| <a title="For more information click here" href="https://aind-data-transfer-service.readthedocs.io" target="_blank" >Help</a> | | |||
| <a href="/login">Sign-In</a> | |||
There was a problem hiding this comment.
Can you add the Sign-In button to the navbar in the other pages? Namely, the Job Status and Job Params pages.
There was a problem hiding this comment.
I am not entirely sure if the Sign-In button is necessary, as it's kind of doesn't add anything. I am actually thinking to remove it. @jtyoung84?
There was a problem hiding this comment.
Replaced with button for Admin page instead
yosefmaru
force-pushed
the
feat-3-user-authentication
branch
from
14a1ecc to
42fc55f
Compare
|
I pushed some changes so that:
I also made some minor changes to update the local setup docs, add styling, and handle an edge case with userinfo not in returned token. Edit: also added logout endpoint. Logout button available on Admin page when user is signed in. |
helen-m-lin
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3