feat: remove _id check for inserts #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtyoung84
reviewed
Jun 12, 2025
| @@ -429,7 +429,10 @@ def aggregate_docdb_records(self, pipeline: List[dict]) -> List[dict]: | |||
|
|
|||
| def insert_one_docdb_record(self, record: dict) -> Response: | |||
| """Insert one new record""" | |||
| if record.get("_id") is None: | |||
| is_managed_collection = ( | |||
There was a problem hiding this comment.
I think it might be better if this logic is handled by the API Gateway. Maybe we can get rid of this check here and just let the api gateway return an error code.
There was a problem hiding this comment.
I moved the _id check for inserts from the client to the lambda function.
helen-m-lin
changed the title
jtyoung84
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to https://github.com/AllenNeuralDynamics/aind-aws-infrastructure/issues/331