Skip to content

DRAFT: fix: Secure x-forwarded-* headers from untrusted proxies #4171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: v3.x.x
Choose a base branch
from

Conversation

richard-salac
Copy link
Contributor

@richard-salac richard-salac commented Jun 17, 2025

Description

Enable forwarding of X-Forwarded... headers from trusted proxies only, mitigates CVE-2025-41235. The pattern to identify trusted proxies can be set via apiml.security.forwardHeader.trustedProxies property. If the request is signed by the Zowe certificate, it is trusted even of the property is not set.

If the headers are received from an untrusted source, they are removed from the request and apiml creates new ones.

cherry-pick from v2: #4148

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@github-actions github-actions bot added the Sensitive Sensitive change that requires peer review label Jun 17, 2025
@richard-salac richard-salac changed the base branch from v3.x.x to reboot/update/v3_java_only June 17, 2025 13:30
@richard-salac richard-salac changed the title Secure x-forwarded-* headers from untrusted proxies fix: Secure x-forwarded-* headers from untrusted proxies Jun 17, 2025
Signed-off-by: Richard Salac <[email protected]>
@richard-salac richard-salac changed the title fix: Secure x-forwarded-* headers from untrusted proxies DRAFT: fix: Secure x-forwarded-* headers from untrusted proxies Jun 17, 2025
@richard-salac richard-salac changed the base branch from reboot/update/v3_java_only to v3.x.x June 17, 2025 14:34
@EvaJavornicka EvaJavornicka moved this from New to In Progress in API Mediation Layer Backlog Management Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sensitive Sensitive change that requires peer review size/XL
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants