-
Notifications
You must be signed in to change notification settings - Fork 45
Add support for DC Electrical Measurement #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
The DC attributes aren't included, so that's why you're seeing the warnings about them being unexpected. |
Agreed. I think pretty much all current uses of extra state attributes should be new entities. Or removed entirely. |
Thanks for taking a look. Should I work on that or if you know exactly what you want to do can you take over? :) |
@puddly Anything I can do here to move on with this PR? |
You should add tests here to fix CI tests Lines 570 to 576 in a2de928
zha/tests/test_cluster_handlers.py Lines 287 to 308 in a2de928
|
@TheJulianJES @puddly @lboue Can you please help with resolving the failures in the tests? I tried locally without any positive results. |
This PR adds support for DC measurements of the ElectricalMeasurement cluster. Only AC is supported now.
I have tested using a local home assistant with the changes implemented, all works fine. Values are in correct resolution.

However, I am receiving warnings in the log:
@puddly Can you please take a look?
Diagnostics file:
zha-01JTN6EVKS6CN88NJXBJPG000P-Espressif ZigbeeElectricalMeasurementDC-c4599a43a5e2d4ab879b05282130e645.json