feat: add keys systemd serviceName option#274
Draft
amerocu wants to merge 1 commit intozhaofengli:mainfrom
Draft
feat: add keys systemd serviceName option#274amerocu wants to merge 1 commit intozhaofengli:mainfrom
amerocu wants to merge 1 commit intozhaofengli:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new option in the keys attribute set to override the key service name. The default service name remains the name of the key suffixed with "-key" BUT the semantics changes a bit.
With this key declaration:
Before the service would have called
my-secret-keywhile then it will be calledmy-pretty-secret-key. I think it's better to use the actual value of keynameinstead of the default value for the option keyname.This change also allows referring to the service name with the option
config.deployment.keys.my-secret.serviceNamein other services.Fixes #141