Fix repl in presence of additional experimental features#268
Open
pr2502 wants to merge 1 commit intozhaofengli:mainfrom
Open
Fix repl in presence of additional experimental features#268pr2502 wants to merge 1 commit intozhaofengli:mainfrom
pr2502 wants to merge 1 commit intozhaofengli:mainfrom
Conversation
Atemu
approved these changes
Mar 26, 2025
Atemu
left a comment
Atemu
left a comment
There was a problem hiding this comment.
I hit this bug and doing this fixes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the other places which shell out to
nixadd their required features using--extra-experimental-features, this PR brings thenix replinvocation in line with them and makes sure thatcolmena replcan work with a configuration which requires more experimental features than justnix-commandandflakes, for examplepipe-operator(which is why i've noticed).