feat(values): Add --set-values and --set-variables flags #4236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kit Patella <[email protected]>
…flags to package create,deploy and inspect cmds with --set Signed-off-by: Kit Patella <[email protected]>
…options Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
…tion Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
…m chart value overrides Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
…n using zarf to helm values mappings Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
…than i expected Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
…d ensure value.Extract has unit test coverage Signed-off-by: Kit Patella <[email protected]>
…d rework SetValue parsing and setting into its own function that is also tested. Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
… text file Signed-off-by: Kit Patella <[email protected]>
…emplate - and default to false Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
Signed-off-by: Kit Patella <[email protected]>
…to --set-varibles Signed-off-by: Kit Patella <[email protected]>
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Kit Patella <[email protected]>
mkcp
changed the title
mkcp
commented
Oct 6, 2025
Comment on lines
+26
to
+27
| --create-set stringToString [alias for --set-variables] Specify package variables to set on the command line (KEY=value) (default []) | ||
| --deploy-set stringToString [alias for --set-variables] Specify deployment variables to set on the command line (KEY=value) (default []) |
Contributor
Author
There was a problem hiding this comment.
This was an unexpected result from changing the other flags. Need to look more into how dev deploy is generated and see about --create-set-variables --deploy-set-variables and --deploy-set-values
Signed-off-by: Kit Patella <[email protected]>
Codecov Report❌ Patch coverage is
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Kit Patella <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
--set-valuesflag with e2e coverage and examples documentation and adds--set-variableswhich is an alias for the current behavior of--set. The reason for --set-variables is to have logical parity with the new flag, and swap over--setto--set-valuesat some point in the future. This allows us to already have a deprecation path ready for users, and to ensure the flags are self-documenting in the mean time.Do not merge this PR until #4136 is merged into main.
Related Issue
Fixes #4224
Checklist before merging