Skip to content

fix(tabs): tabRect could be undefined #5767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
superlbr wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(tabs): tabRect could be undefined #5767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/tabs/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,13 +276,15 @@ VantComponent({
getRect(this, '.van-tabs__nav'),
]).then(([tabRects, navRect]) => {
const tabRect = tabRects[currentIndex];
const offsetLeft = tabRects
if (tabRect) {
Copy link
Contributor

@landluck landluck Apr 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

什么情况下 tabRect 不存在？

Copy link
Author

@superlbr superlbr Apr 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@landluck 小程序错误统计里有的

const offsetLeft = tabRects
.slice(0, currentIndex)
.reduce((prev, curr) => prev + curr.width, 0);

this.setData({
scrollLeft: offsetLeft - (navRect.width - tabRect.width) / 2,
});
this.setData({
scrollLeft: offsetLeft - (navRect.width - tabRect.width) / 2,
});
}

if (!scrollWithAnimation) {
nextTick(() => {
Expand Down