fix(Dialog): fix button color with different theme #5723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landluck
reviewed
Mar 12, 2024
packages/dialog/index.ts
Outdated
| type: Boolean, | ||
| observer(show: boolean) { | ||
| !show && this.stopLoading(); | ||
| this.handleButtonColor(); |
landluck
reviewed
Apr 15, 2024
| var RED = '#ee0a24'; | ||
| var WHITE = '#fff'; | ||
| var GRAY = '#323233'; | ||
| function buttonColor(data) { |
Contributor
There was a problem hiding this comment.
这里有两个改造思路，一个是 RED 这些JS变量是不是可以用全局的 CSS 变量，这里本身是 style，理论上是可以用的，避免在维护一套JS的样式变量
另外一个是这个函数是不是可以统一改造根据不同的条件回生效不同的样式，目前的实现可复用度比较低
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5722 当theme为round-button时 confirmButtonColor的默认值RED被透传 需要判断处理一下