Skip to content

fix: golangci lint was not passing anymore #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025

Conversation

toby-bro
Copy link
Contributor

@toby-bro toby-bro commented Mar 29, 2025

This PR #1706 fixes the issue too but also did lots of things so opening a simpler PR just for fixing the CI

before

❯ golangci-lint run --color=always ./... --timeout=10m
WARN [lintersdb] The name "vet" is deprecated. The linter has been renamed to: govet. 
modules/gitter/widget.go:71:5: S1009: should omit nil check; len() for nil slices is defined as zero (gosimple)
        if widget.messages == nil || len(widget.messages) == 0 {
           ^

now it passes the ci

edit :
fixes #1721

@toby-bro toby-bro changed the title fix: golangci lint not passing anymore fix: golangci lint was not passing anymore Mar 29, 2025
@FelicianoTech
Copy link
Collaborator

This looks great. Thank you for the PR, and for your first one to the project at that! 👏🏽

@FelicianoTech FelicianoTech merged commit 8bd2ec4 into wtfutil:master Jun 14, 2025
5 checks passed
@FelicianoTech FelicianoTech added this to the v0.44.0 milestone Jun 17, 2025
@toby-bro
Copy link
Contributor Author

@FelicianoTech I'd be really happy if you could also check out these two MR please 🙃 #1718 and #1719
Thanks for having accepted this one (I really was sad thinking this project had been abandonned)

@FelicianoTech
Copy link
Collaborator

@toby-bro No worries, I'll get to them. I plan to get to every open issue and PR that's on this project currently. If you haven't seen it, I posted a loose plan for the next two releases here: #1725

@toby-bro
Copy link
Contributor Author

Sorry I hadn't seen it, seems great, thanks ! I'd be happy to help on stuff, didn't do much as I thought the project was dead but definitely interested into helping it thrive again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

golanci-lint not happy anymore so CI not passing
2 participants