Return null from Num.fromString when strtod parses nothing#1232
Open
cuiweixie wants to merge 1 commit into
Open
Return null from Num.fromString when strtod parses nothing#1232cuiweixie wants to merge 1 commit into
cuiweixie wants to merge 1 commit into
Conversation
cuiweixie
force-pushed
the
fix/num-fromstring-strtod-no-parse
branch
from
6d1b186 to
3c1c70e
Compare
If strtod performs no conversion, end equals the input pointer; return null immediately. Without this, whitespace-only strings (e.g. three spaces) incorrectly returned 0: the trailing-whitespace loop advanced end to the terminator so the full-string check passed. Add a regression test for whitespace-only input.
cuiweixie
force-pushed
the
fix/num-fromstring-strtod-no-parse
branch
from
3c1c70e to
fa7ba63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After
strtod, if no conversion was performed,endis unchanged (end == string->valueper POSIX). Returnnullimmediately instead of running the trailing-whitespace and length checks on that path.Tests