Return from addConstant when constant limit is exceeded#1231
Open
cuiweixie wants to merge 1 commit into
Open
Conversation
Without returning after the error, execution fell through and returned compiler->fn->constants.count - 1, which could emit invalid bytecode.
cuiweixie
force-pushed
the
fix/addconstant-return-on-max-constants
branch
from
60c7cc9 to
df29737
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
addConstant, whenMAX_CONSTANTSis exceeded we callerror()but previously did not return. Execution then fell through toreturn compiler->fn->constants.count - 1, which could emit bytecode with a bogus constant index.Return
-1after reporting the error (consistent with other failure paths in the compiler).Testing