Add integer division method Num.quo#1148
Open
PureFox48 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far back as #127 @munificent admitted that an integer division operator was a 'missing piece' in Wren's treatment of integers as it was tedious having to write
(a/b).truncateall the time.I opened a discussion about this in #907 but it was decided there was no suitable symbol available. This left the possibility of adding an instance method to the Num class:
a.div(b)ora.quo(b)instead and I felt that the latter was preferable as it was more suggestive of integer division.Although I decided to close the issue at the time, after two more years tedium of having to write
(a/b).truncateI've concluded thata.quo(b)would be a sensible 'best effort' for this, particularly if we implement it in C to maximize performance. Hence the reason for this PR.