Conversation
There was a problem hiding this comment.
Pull request overview
Upgrades the monorepo’s TypeScript toolchain to v6.0.2 and simplifies tsconfig settings based on the new defaults, with an additional type shim for CSS imports in the test app.
Changes:
- Bump TypeScript from 5.9.2 to 6.0.2 for the root workspace lockfile and updated workspaces.
- Remove explicit
"strict": truefrom several tsconfig files (relying on TS 6’s default strictness). - Add a
*.cssmodule declaration for thetestworkspace and adjustreact-date-pickertsconfig options.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updates locked TypeScript resolution to 6.0.2. |
| test/tsconfig.json | Removes explicit strict from test project tsconfig. |
| test/package.json | Bumps TypeScript devDependency to ^6.0.2. |
| test/global.d.ts | Adds ambient module declaration for *.css imports. |
| sample/tsconfig.json | Removes explicit strict from sample project tsconfig. |
| packages/react-date-picker/tsconfig.json | Removes explicit strict and adds rootDir. |
| packages/react-date-picker/package.json | Bumps TypeScript devDependency to ^6.0.2. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "noEmit": true, | ||
| "noUncheckedIndexedAccess": true, | ||
| "skipLibCheck": true, | ||
| "strict": true, | ||
| "target": "esnext", | ||
| "verbatimModuleSyntax": true |
There was a problem hiding this comment.
Removing "strict": true here is only redundant if this package is compiled with TypeScript 6+, where strict defaults to true. In this repo, sample/package.json still pins typescript to ^5.9.2, so omitting strict will actually disable strict mode for the sample project. Either bump sample's TypeScript dependency (and its lockfile) to 6.0.2 as well, or keep "strict": true (or set it explicitly) in this tsconfig.
Upgrade TypeScript to 6.0.2 and remove redundant strict config.