test: add 13 e2e tests covering major coverage gaps#1936
Merged
Conversation
Consolidate duplicated shape-selection logic from canvas_interaction_test.py and shape_editing_test.py into a shared select_shape() function in the e2e conftest module.
wkentaro
force-pushed
the
test/e2e-coverage-gaps
branch
2 times, most recently
from
1447665 to
2529a17
Compare
_save_and_check relied on auto-save having already updated self._label_file to point to output_dir. Under CI load (Ubuntu, xdist with 4 workers), the signal chain from mouseRelease → shapeMoved → setDirty → saveLabels could race with the test proceeding. Fix by calling saveLabels with the explicit target path instead of going through _save_label_file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
select_shapehelper to e2e conftest (dedup from 3 files)Why
Coverage analysis identified these as the highest-impact gaps — core editing workflows (copy/paste, undo), common features (zoom, brightness, visibility), and file operations (close, delete, auto-save) all had zero e2e coverage. This brings overall coverage from 73% to 76%, with brightness_contrast_dialog.py jumping from 19% to 92%.
Test plan
make test)make lint— ruff, ty, typos)make coverage— 76%, up from 73%)