fix: point shapes are now selectable and deletable by clicking#1860
Merged
fix: point shapes are now selectable and deletable by clicking#1860
Conversation
0dc68d1 to
0891737
Compare
0891737 to
23371dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Point shapes placed on the canvas cannot be selected or deleted by clicking on them.
Shape.containsPoint()callsself.makePath().contains(point), but a point shape's path is zero-area (a single zero-length line), soQPainterPath.contains()always returnsFalse.This makes point annotations effectively stuck — impossible to select, move, or delete after creation.
Fixes #1524.
Solution
Add an early return in
containsPoint()forshape_type == "point"that uses the actual rendered hit radius (point_size / 2) instead of path containment:This mirrors the visual size of the drawn point handle and gives users a natural click target.
Tests
Added
tests/unit/shape_contains_point_test.pywith 4 cases:Truepoint_size / 2→Truepoint_size / 2away →FalseFalse(no crash)All 40 unit tests pass.