rewrite: app.py Phase 3-C — action definitions (menu items)#1856
Merged
rewrite: app.py Phase 3-C — action definitions (menu items)#1856
Conversation
c8bc352 to
3e168a2
Compare
Owner
Author
|
Closing in favor of a more meaningful refactor. Rather than just rewriting variable assignments in place, we're restructuring |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites the action definitions section of
labelme/app.py(lines ~248–412) to use consistent explicit keyword arguments throughout.What changed
All
action()calls in the menu-action setup block now use explicit keyword parameters (text=,slot=,shortcut=,icon=,tip=, etc.) instead of a mix of positional and keyword arguments.Affected actions:
quit,open_,opendir,openNextImg,openPrevImgsave,saveAs,deleteFile,changeOutputDirsaveAuto,saveWithImageData,closetoggle_keep_prev_modecreateMode,createRectangleMode,createCircleMode,createLineMode,createPointMode,createLineStripModeBehavior
No functional change. All
tr()strings, shortcuts, icons, and callbacks are identical to before. ThesaveAutolambda parameter was renamed fromxtocheckedfor clarity.Tests
36 unit tests pass (
python3 -m pytest tests/unit/ -k "not qapp").