refactor: add type annotations to utils/image.py#1832
Open
Conversation
Add full type annotations to all 9 functions in labelme/utils/image.py: - img_data_to_pil(bytes) -> PIL.Image.Image - img_data_to_arr(bytes) -> NDArray[np.uint8] - img_b64_to_arr(str) -> NDArray[np.uint8] - img_pil_to_data(PIL.Image.Image) -> bytes - img_arr_to_b64(NDArray[np.uint8]) -> str - img_arr_to_data(NDArray[np.uint8]) -> bytes - img_data_to_png_data(bytes) -> bytes - img_qt_to_arr(QtGui.QImage) -> NDArray[np.uint8] - apply_exif_orientation(PIL.Image.Image) -> PIL.Image.Image Also add: - from numpy.typing import NDArray import - optional qtpy.QtGui import (with fallback for type annotation use only) No logic changes.
… imageData non-None at call sites
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add full type annotations to all 9 functions in
labelme/utils/image.py. No logic changes.Changes
New imports
from numpy.typing import NDArrayfrom qtpy import QtGui(withImportErrorfallback; used only for theimg_qt_to_arrannotation)Annotated functions
img_data_to_pil(bytes) -> PIL.Image.Imageimg_data_to_arr(bytes) -> NDArray[np.uint8]img_b64_to_arr(str) -> NDArray[np.uint8]img_pil_to_data(PIL.Image.Image) -> bytesimg_arr_to_b64(NDArray[np.uint8]) -> strimg_arr_to_data(NDArray[np.uint8]) -> bytesimg_data_to_png_data(bytes) -> bytesimg_qt_to_arr(QtGui.QImage) -> NDArray[np.uint8]apply_exif_orientation(PIL.Image.Image) -> PIL.Image.Image