Feature/brush tool by kancheng · Pull Request #1728 · wkentaro/labelme

kancheng · 2026-01-05T23:15:28Z

This PR focuses only on the brush drawing tool:

Add brush size control
Add a cancel/delete action for brush drawing
Fix a Qt6 crash caused by float arguments passed to QPainter.drawEllipse
Update brush button positions

No localization or unrelated changes are included.

…(or rounding) before calling QPainter.drawEllipse. Mouse positions can be QPointF, producing float coordinates that do not match the int overload.

kancheng · 2026-01-05T23:16:00Z

demo details

kancheng · 2026-01-06T01:04:29Z

如需詳細演示，請參閱：#1726

kancheng · 2026-01-07T22:45:07Z

@wkentaro

I wanted to briefly explain the current CI status. At the moment, the only failing check is:

ci / check (pull_request)

In this PR, the only functional changes I made are in canvas.py (related to the drawing/brush functionality). The other CI jobs (builds on macOS, Ubuntu, and Windows) are all passing successfully, so there are no runtime or cross-platform issues.

I’ve just updated my branch to be fully in sync with the latest upstream state to avoid any drift. Based on my local testing and the successful build checks, the feature itself should be stable and mature at this point.

kirillmeisser · 2026-01-29T09:52:57Z

Hi, @kancheng thanks for your work! Me and my company would also be very interested in this feature. What is holding it back from being merged? Or do you know why the ci / check job is failing?

minewilliam

I have not had time to test/review the functionality yet. This is more of my impression of your PR at a glance.

I think a mistake was made somewhere in a merge with main, 2 months ago. Please review your PR and make sure it does not incur a regression. Ex: type hints were added to the parameters of event handlers.
You said you did not add translation in this PR, but you have 2 translation files commited?

PS: I apologize for the number of identical comments in my review.

minewilliam · 2026-02-11T22:00:28Z

labelme/widgets/label_dialog.py

+    def keyPressEvent(self, e):
+        if e.key() in [QtCore.Qt.Key_Up, QtCore.Qt.Key_Down]:
+            self.list_widget.keyPressEvent(e)
        else:
-            super().keyPressEvent(a0)
+            super().keyPressEvent(e)


This file should be reverted.
Source commit: 4d468d7#diff-20a434242a3644257f0c023ee8b47787fb12f85bd0dfeab0e3c059660b076bc3R19

minewilliam · 2026-02-11T22:04:39Z

labelme/widgets/unique_label_qlist_widget.py

+    def keyPressEvent(self, event):
+        super().keyPressEvent(event)
+        if event.key() == Qt.Key_Escape:


This file should be reverted.
Source commit: 4d468d7#diff-7b04d17815ef0375466c70d68d5cccee332fff0cbf5753a866df82b9b5b92700R4

minewilliam · 2026-02-11T22:08:07Z

labelme/__main__.py

-        if stripped_s := s.strip():
-            logger.debug(stripped_s)
-        return len(s)
+    def write(self, message: str) -> int:


This file should be reverted.
Source commit: d05d6fa#diff-c29d43c632d9da4dd3b6284c58535d13128b46307a8231603ecb779763087c5bR24

minewilliam · 2026-02-11T22:16:01Z

labelme/_label_file.py

    description: str
    group_id: int | None
-    mask: NDArray[np.bool] | None
+    mask: NDArray[np.bool_] | None


This file should be reverted.
np.bool_ is an alias for np.bool: The latter being preferable.
dict was replaced by ShapeDict in this commit: 0e15b8c#diff-9e7397e710163a6540ac179927130394d44dfd90e0fcb81af6c8efa9a1b88e18R110

minewilliam · 2026-02-11T22:18:46Z

labelme/app.py

+        self._brushSizeSlider.valueChanged.connect(
+            lambda value: self._on_brush_size_changed(value)
+        )


Suggested change

self._brushSizeSlider.valueChanged.connect(

lambda value: self._on_brush_size_changed(value)

)

self._brushSizeSlider.valueChanged.connect(self._on_brush_size_changed)

minewilliam · 2026-02-12T16:38:57Z

labelme/widgets/canvas.py

        return len(self.current) >= 3

-    def mouseDoubleClickEvent(self, a0: QtGui.QMouseEvent) -> None:
+    def mouseDoubleClickEvent(self, ev):


Revert this change.

minewilliam · 2026-02-12T16:39:42Z

labelme/widgets/canvas.py

+    def mouseReleaseEvent(self, ev):
+        if ev.button() == Qt.RightButton:
            menu = self.menus[len(self.selectedShapesCopy) > 0]
            self.restoreCursor()
-            if not menu.exec_(self.mapToGlobal(a0.pos())) and self.selectedShapesCopy:  # type: ignore
+            if not menu.exec_(self.mapToGlobal(ev.pos())) and self.selectedShapesCopy:
                # Cancel the move by deleting the shadow copy.
                self.selectedShapesCopy = []
                self.repaint()
-        elif a0.button() == Qt.LeftButton:
+        elif ev.button() == Qt.LeftButton:


Revert this change.

minewilliam · 2026-02-12T16:40:11Z

labelme/widgets/canvas.py

+    def mousePressEvent(self, ev):
+        pos: QPointF = self.transformPos(ev.localPos())

-        is_shift_pressed = a0.modifiers() & Qt.ShiftModifier
+        is_shift_pressed = ev.modifiers() & Qt.ShiftModifier

-        if a0.button() == Qt.LeftButton:
+        if ev.button() == Qt.LeftButton:


Revert this change.

minewilliam · 2026-02-12T16:40:29Z

labelme/widgets/canvas.py

+    def mouseMoveEvent(self, ev):
        """Update line with last point and current coordinates."""
        try:
-            pos = self.transformPos(a0.localPos())
+            pos = self.transformPos(ev.localPos())
        except AttributeError:
            return

        self.mouseMoved.emit(pos)

        self.prevMovePoint = pos

-        is_shift_pressed = a0.modifiers() & Qt.ShiftModifier
+        is_shift_pressed = ev.modifiers() & Qt.ShiftModifier


Revert this change.

minewilliam · 2026-02-12T16:40:44Z

labelme/widgets/canvas.py

+    def enterEvent(self, ev):
        self.overrideCursor(self._cursor)
        self._update_status()

-    def leaveEvent(self, a0: QtCore.QEvent) -> None:
+    def leaveEvent(self, ev):
        self.unHighlight()
        self.restoreCursor()
        self._update_status()

-    def focusOutEvent(self, a0: QtGui.QFocusEvent) -> None:
+    def focusOutEvent(self, ev):
        self.restoreCursor()
        self._update_status()


Revert this change.

kancheng added 7 commits January 6, 2026 07:02

Added

d5d2079

Added the ability to control the size of the brush.

a7daa16

Fix brush painting crash on Qt6 by casting ellipse parameters to int …

8edce80

…(or rounding) before calling QPainter.drawEllipse. Mouse positions can be QPointF, producing float coordinates that do not match the int overload.

Add delete button next to Save to discard current annotation

ce6dbf7

Fixed button

b6dd1e4

Fixed

cd56ddf

update brush button positions

ccd96b0

kancheng force-pushed the feature/brush-tool branch from 2f3cb48 to ccd96b0 Compare January 7, 2026 21:57

kancheng added 6 commits January 8, 2026 06:00

Fixed

504bf19

Merge branch 'main' into feature/brush-tool

902c2c9

Fixed

3cc2e95

Clear brush painting if switching away from brush mode

f995213

iAdded

7b7d461

Fixed

e3ea295

kancheng added 3 commits January 8, 2026 22:41

Merge branch 'wkentaro:main' into feature/brush-tool

890540e

Merge branch 'wkentaro:main' into feature/brush-tool

3448847

Merge branch 'wkentaro:main' into feature/brush-tool

025c772

wkentaro added this to @wkentaro's Kanban Jan 10, 2026

github-project-automation bot moved this to Backlog in @wkentaro's Kanban Jan 10, 2026

wkentaro added the feature label Jan 10, 2026

kancheng added 5 commits January 13, 2026 13:39

Merge branch 'wkentaro:main' into feature/brush-tool

164b02c

Merge branch 'main' into feature/brush-tool

8bddc00

Fixed

123011e

Merge remote-tracking branch 'origin/main' into feature/brush-tool

aae6788

Merge branch 'wkentaro:main' into feature/brush-tool

c072f91

minewilliam suggested changes Feb 12, 2026

View reviewed changes

Conversation

kancheng commented Jan 5, 2026

Uh oh!

kancheng commented Jan 5, 2026

Uh oh!

kancheng commented Jan 6, 2026

Uh oh!

kancheng commented Jan 7, 2026

Uh oh!

kirillmeisser commented Jan 29, 2026

Uh oh!

minewilliam left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

minewilliam Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

minewilliam Feb 11, 2026 •

edited

Loading