Skip to content

feat: add .map() method #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2025
Merged

feat: add .map() method #147

merged 2 commits into from
Jun 30, 2025

Conversation

snowyu
Copy link
Contributor

@snowyu snowyu commented Jun 21, 2025

Make life more easy:

const tokensWithPOS = doc.tokens().map(token => ({token: token.out(), pos: token.out(its.pos)}))

@CLAassistant
Copy link

CLAassistant commented Jun 21, 2025

CLA assistant check
All committers have signed the CLA.

@sanjayaksaxena
Copy link
Member

Many thanks for your contribution @snowyu. We will review the PR shortly and accordingly merge.

@sanjayaksaxena
Copy link
Member

The following line remains not covered by tests:

image

Would it possible for you to include test cases for the same?

Running npm run test will help you validate via coverage details generated under the coverage directory.

Thank you.

@snowyu
Copy link
Contributor Author

snowyu commented Jun 30, 2025

Ok, done.

Copy link
Member

@sanjayaksaxena sanjayaksaxena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@sanjayaksaxena sanjayaksaxena merged commit 76cd866 into winkjs:master Jun 30, 2025
3 checks passed
@sanjayaksaxena
Copy link
Member

Published version 2.4.0 on npm as well. Documentation update remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants