-
Notifications
You must be signed in to change notification settings - Fork 24
[Snyk] Security upgrade react-router-dom from 6.26.1 to 7.0.0 #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Snyk] Security upgrade react-router-dom from 6.26.1 to 7.0.0 #131
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-REMIXRUNROUTER-14908530 - https://snyk.io/vuln/SNYK-JS-REACTROUTER-14908286 - https://snyk.io/vuln/SNYK-JS-REMIXRUNROUTER-14908287
|
Important Review skippedIgnore keyword(s) in the title. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @shamoilattaar-wednesday, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the application's security posture by upgrading the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, upgrades react-router-dom to address security vulnerabilities. However, this introduces two significant risks. First, react-router-dom is upgraded to v7.0.0, which is a pre-release version. Using pre-release software in production is highly discouraged due to instability and breaking changes. Second, @react-native-async-storage/async-storage is downgraded from v2.0.0 to v1.23.1, which is also a major version change that can cause breakages. I have added comments on both package.json and yarn.lock to highlight these critical issues. Please review these changes carefully and perform extensive testing before merging.
I am having trouble creating individual review comments. Click here to see my feedback.
package.json (86)
This change upgrades react-router-dom to v7.0.0, which is a major version bump. The resolved version in yarn.lock is 7.12.0, which appears to be a pre-release version. Using pre-release versions in production is highly discouraged due to potential instability, bugs, and further breaking changes.
It is critical to:
- Verify the stability requirements of this project and confirm if using a pre-release is acceptable.
- Review the migration guide for
react-routerv7 for breaking changes. - Perform thorough regression testing on all routing-related features.
If a pre-release is not suitable, consider waiting for a stable v7 release or exploring alternative mitigations for the security vulnerabilities.
yarn.lock (2202-2205)
This part of the lockfile change indicates a major version downgrade for @react-native-async-storage/async-storage from v2.0.0 to v1.23.1. This was likely an automatic correction by yarn to match package.json, but it's a significant change that can introduce breaking changes.
Please ensure this downgrade is intentional and thoroughly test all functionality that relies on async-storage to prevent regressions.
Coverage reportStatements coverage not met for global: expected >=80%, but got 79.09604519774011%
Test suite run success47 tests passing in 17 suites. Report generated by 🧪jest coverage report action from 2702c7e |
Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
package.jsonyarn.lockNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-REMIXRUNROUTER-14908530
SNYK-JS-REACTROUTER-14908286
SNYK-JS-REMIXRUNROUTER-14908287
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Open Redirect
🦉 Cross-site Scripting (XSS)