test+docs: cover type aliases, document -schemaHash#8
Open
klaidliadon wants to merge 1 commit into
Open
Conversation
- add `type UserID: uint64` alias to Tests/test.ridl and a test asserting it renders as a typealias to the underlying type and is usable as a request field — alias rendering previously had zero coverage - document the -schemaHash opt-out in the README options table Generated.swift is gitignored and regenerated by Tests/test.sh in CI, where `swift test` compiles and exercises the alias.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two release-readiness fixes for gen-swift:
type Name: Baseas a Swifttypealias, but nothing exercised it (no alias in the test schema, no assertion). Addedtype UserID: uint64toTests/test.ridland a test asserting it resolves to the underlying type and is usable as a request field.-schemaHashopt-out in the README options table.Tests/Sources/Generated/Generated.swiftis gitignored and regenerated byTests/test.shin CI, so it isn't committed. I regenerated locally with the pinned tool (webrpc-gen v0.37.2) and confirmed the output:I could not run
swift testlocally (no Swift toolchain in my env) — CI'sTests/test.shregenerates and compiles/exercises the alias. Flagging that explicitly rather than claiming the Swift suite passed.Part of the cross-generator sweep documenting
-schemaHashand closing type-alias coverage gaps.