feat: improve file storage and routing #4870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR improves file organization in the file manager S3 bucket. Previously, all files were stored in the root of the bucket, with the file id as a path prefix. You couldn't tell which S3 object belongs to which tenant by simply looking at the bucket.
Now we have a
tenantsfolder, and then a subfolder for each tenant (see screenshots).The file URL remains the same, e.g.:
/files/6966d46bf2d4bb0002595006/image-1.jpg. We extract theidfrom the URL, and perform a simple key-value DB lookup (using the newGlobalKeyValueStoreabstraction), to fetch file metadata required for routing.How Has This Been Tested?
Manually.