Extensions - Hide Page Builder Element Extension #4379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrians5j
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With this PR, we're hiding the PB element extensions, as some of the things that it relies on are not yet ready to go out.
Extra Changes
We also fixed an issue where, when generating a new extension, versions of
@webiny/packages that were already set in the selected extension'spackage.jsonfile (in extension templates, example here), would not get set to the Webiny version that the project is running on.That's why, this PR also closes #4367. Thanks @alifeinbinary for reporting this issue! 😊
How Has This Been Tested?
Manually.
Documentation
Non needed.