Use embedded stylesheet for <details> element
#52853
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 29, 2025
servo-wpt-sync
force-pushed
the
servo_export_36994
branch
from
cc85809 to
373e739
Compare
Signed-off-by: stevennovaryo <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_36994
branch
from
373e739 to
92fd20b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of injecting the style in
<details>shadow tree for each update, we attach an embedded stylesheetlayout/ stylesheet/details.cssfor that shadow DOM. The embedded stylesheet is introduced with it's parsing utilities in the sharedcomponents/shared/script_layout/lib.rsbetweenlayoutandscript.All things considered, it is better to implement the styles inside UA stylesheet. But we will need to support shadow-scoped UA style sheet, as detailed in the discussion.
Testing: No WPT Test Regression
Reviewed in servo/servo#36994