Skip to content

[WIP] Bundle size optimisation#54

Open
jadjoubran wants to merge 1 commit into
web-platform-dx:mainfrom
jadjoubran:main
Open

[WIP] Bundle size optimisation#54
jadjoubran wants to merge 1 commit into
web-platform-dx:mainfrom
jadjoubran:main

Conversation

@jadjoubran

Copy link
Copy Markdown

Hello @rviscomi @kosamari @atopal

As discussed today, this is a work in progress PR to help bring the bundle size down.

I understand that you want to have a single script file that works out of the box, but I was thinking, how about we move these images to a CDN or how about we offer another version of this script where the user must also provide the icons?

I kept the SUPPORT_ICONS because I assumed you want to allow the end user to customise the colors with CSS variables (and it's also only ~6kb of savings for the support icons).

I have other optimisations in mind, but I want to start first with the low hanging fruits, and that is the icons (~35kb).

Let me know what you think! I'm happy to finalise this as I'd like to integrate it in my courses.

Thanks!

@rviscomi

rviscomi commented Apr 1, 2025

Copy link
Copy Markdown
Collaborator

Thanks @jadjoubran! Is this still "WIP" or is it ready for review?

Also tagging related issue #16

@jadjoubran

Copy link
Copy Markdown
Author

Hey @rviscomi
It depends on your answer to this question:

I understand that you want to have a single script file that works out of the box, but I was thinking, how about we move these images to a CDN or how about we offer another version of this script where the user must also provide the icons?

@rviscomi

rviscomi commented Apr 1, 2025

Copy link
Copy Markdown
Collaborator

Moving the images out of the JS seems like a good first step. Eventually, we may want to host the SVGs externally, or reuse the PNGs that webstatus.dev already makes public, eg https://webstatus.dev/public/img/chrome_24x24.png. @bramus also suggested something similar in #16 (comment)

cc @brendankenny

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants