Skip to content

chore: fix test cases #7287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2025
Merged

Conversation

yimingjfe
Copy link
Member

@yimingjfe yimingjfe commented Jun 30, 2025

Summary

rsbuild has updated the rules for swc-loader and babel-loader.:

// before
        include: [
          {
            and: [
              '/modern-js-main.js/tests/integration/rsc-ssr-app',
              {
                not: /[\\/]node_modules[\\/]/
              }
            ]
          },
          /\.(?:ts|tsx|jsx|mts|cts)$/,
          /node_modules\/react-router/,
          /node_modules\/react-router-dom/,
          /node_modules\/@remix-run\/router/,
          '/Users/bytedance/Desktop/workspace/modern-js-main.js/tests/integration/rsc-ssr-app/node_modules/.modern-js'
        ],
// after
        include: [
          {
            not: /[\\/]node_modules[\\/]/
          },
          /\.(?:ts|tsx|jsx|mts|cts)$/,
          /node_modules\/react-router/,
          /node_modules\/react-router-dom/,
          /node_modules\/@remix-run\/router/,
          '/Users/bytedance/Desktop/workspace/modern-js-main.js/tests/integration/rsc-ssr-app/node_modules/.modern-js'
        ],

This will cause universal/async_storage.server.js to be processed by rsc-server-loader and rsc-ssr-loader, resulting in two copies of the async_storage.server.js file in the output

Related Links

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Jun 30, 2025

⚠️ No Changeset found

Latest commit: c1cdd21

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jun 30, 2025

Deploy Preview for modernjs-byted ready!

Name Link
🔨 Latest commit c1cdd21
🔍 Latest deploy log https://app.netlify.com/projects/modernjs-byted/deploys/68634ab71be0d50009a4b117
😎 Deploy Preview https://deploy-preview-7287--modernjs-byted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 80 (🟢 up 2 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@yimingjfe yimingjfe enabled auto-merge (squash) June 30, 2025 06:04
@yimingjfe yimingjfe merged commit f4e7339 into web-infra-dev:main Jul 1, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants