Skip to content

WIP fix: the script declare runWindowFn and runRouterDataFn should never async #7177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zllkjc
Copy link
Member

@zllkjc zllkjc commented May 21, 2025

Summary

Related Links

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented May 21, 2025

⚠️ No Changeset found

Latest commit: c8b05bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented May 21, 2025

Deploy Preview for modernjs-byted ready!

Name Link
🔨 Latest commit c026102
🔍 Latest deploy log https://app.netlify.com/projects/modernjs-byted/deploys/682ed55e951d2400087b7cb3
😎 Deploy Preview https://deploy-preview-7177--modernjs-byted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 57 (🔴 down 21 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@zllkjc zllkjc changed the title WIP fix: the script declare runWindowFn and runRouterDataFn should never … WIP fix: the script declare runWindowFn and runRouterDataFn should never async May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant