-
Notifications
You must be signed in to change notification settings - Fork 923
fix(chrome-extension): add start/stop controls for bridge mode #2177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4bec457
fix(chrome-extension): add start/stop controls for bridge mode
quanru a11b50a
fix(chrome-extension): add bridge toggle button styles
quanru 3f8aa0e
fix(chrome-extension): add bridge unit tests to CI workflow
quanru 3abab8d
fix(chrome-extension): scope CI unit test to bridge-start-stop only
quanru 29ea3db
fix(chrome-extension): use vitest file path filter instead of jest flag
quanru df25c06
fix(chrome-extension): add bridge unit test report to CI artifacts
quanru ea98fd9
fix(chrome-extension): add e2e test for bridge mode start/stop (#2119)
quanru 6a8253f
fix(chrome-extension): add retry for bridge mode e2e switch and impro…
quanru 05f56dc
fix(chrome-extension): simplify bridge e2e test to avoid timeout
quanru c359c94
fix(chrome-extension): split bridge e2e test into standalone file
quanru bfeaae2
fix(chrome-extension): add real bridge connection e2e test
quanru 06ddc4a
fix(chrome-extension): inject bridge alwaysAllow permission in e2e test
quanru 52c8578
fix(chrome-extension): inject bridge permission via service worker CDP
quanru 495d54f
fix(chrome-extension): treat disconnected as active in bridge toggle
quanru 14fe38c
fix(chrome-extension): persist bridge stopped state across SW restarts
quanru File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This handler makes
Stoplook permanent, butBRIDGE_STOPonly tears down the current worker instance. The extension is declared as an MV3background.service_worker(apps/chrome-extension/static/manifest.json:5-17), andworker.tsstill unconditionally runsinitBackgroundBridge()plussafeSetupKeepalive({ shouldEnable: true })at module load (apps/chrome-extension/src/scripts/worker.ts:352-379). After any normal service-worker restart, the bridge starts listening again, so users who stopped bridge mode can be silently re-exposed to incoming connections.Useful? React with 👍 / 👎.