Fix text clipping in search input#457
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix text clipping issue in search input
Fix text clipping in search input
Jul 4, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes descender/ascender clipping in the search input by explicitly setting its line-height to match the site’s base typography, avoiding browser-specific <input> default line-height behavior.
Changes:
- Set
line-height: $base-line-heighton.search__inputto align input text metrics with the globalhtml { line-height: $base-line-height; }.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The search input clips descenders (e.g.
g,p) due to browsers applying a tighter defaultline-heightto<input>elements. This worsens with non-Latin characters that have more extreme ascenders/descenders.Change
line-height: $base-line-heightto.search__inputinsearch.scssThe
@include fs(m)mixin only setsfont-size;line-heightmust be set explicitly on inputs to match the rest of the site (1.6).