-
Notifications
You must be signed in to change notification settings - Fork 35
Remove the TAG from the groups responsible for this document. #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This should solve this #185
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. My only suggestion, which I think appropriate for including as part of this PR removing the TAG from the groups responsible, is to somewhere (Acknowledgments? up to editor discretion) note that this document was originally created by the TAG (or equivalent wording). Origins matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvements @jyasskin certainly along the intent of my suggestion. Appreciated. Added a minor suggested change highlighting the significance of TAG's past role. Up to editor discretion.
Co-authored-by: Tantek Çelik <[email protected]>
fwiw, i think this looks great |
This is ready for review, @pes10k and @simoneonofri.
Preview | Diff