Skip to content

Conversation

@mondragonfx
Copy link
Contributor

@mondragonfx mondragonfx commented Mar 13, 2025

Description

Added Support for:

HTTP2/3
Timeout
GlobalRegions
Base64 SSL options
AutoSSL

Related Issues

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@mondragonfx mondragonfx requested a review from optik-aper as a code owner March 13, 2025 17:41
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noted some changes and I think overall, my thoughts are that there are too many flags doing the slightly different things on the same command. I would like to split all ssl logic into the ssl sub-command. Also formatting of the input data as b64 seems inappropriate as an entirely separate flag even though that's how the API is designed, though I'm not sure there's a better solution.

@optik-aper optik-aper linked an issue Mar 14, 2025 that may be closed by this pull request
@optik-aper optik-aper added the enhancement New feature or request label Mar 14, 2025
@optik-aper optik-aper self-requested a review April 15, 2025 13:54
@mondragonfx mondragonfx force-pushed the update-loadbalancer-options branch from af469d4 to c6339a4 Compare June 4, 2025 16:17
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working

@optik-aper optik-aper merged commit e906acb into vultr:master Jun 11, 2025
3 checks passed
@optik-aper optik-aper mentioned this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] - LB update timeout missing

2 participants