Update Load Balancer CLI options #521
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optik-aper
requested changes
Mar 14, 2025
There was a problem hiding this comment.
I've noted some changes and I think overall, my thoughts are that there are too many flags doing the slightly different things on the same command. I would like to split all ssl logic into the ssl sub-command. Also formatting of the input data as b64 seems inappropriate as an entirely separate flag even though that's how the API is designed, though I'm not sure there's a better solution.
cmd/loadbalancer/loadbalancer.go
Outdated
| @@ -180,11 +180,41 @@ func NewCmdLoadBalancer(base *cli.Base) *cobra.Command { //nolint:funlen,gocyclo | |||
| return fmt.Errorf("error parsing flag 'ssl-redirect' for load balancer create : %v", errSs) | |||
| } | |||
|
|
|||
| domainZone, errDz := cmd.Flags().GetString("auto-ssl-domain-zone") | |||
There was a problem hiding this comment.
Looking at these, I wonder if we should shift the relevant SSL functions all under the ssl sub-command along with the delete and auto ssl disable.
ssl:
- add
- delete
- update
- disable-auto-ssl
There was a problem hiding this comment.
It would make sense to move certificate logic into this sub-command as well.
optik-aper
requested changes
Mar 19, 2025
optik-aper
requested changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Support for:
HTTP2/3
Timeout
GlobalRegions
Base64 SSL options
AutoSSL
Related Issues
Checklist: