Skip to content

Conversation

@mothsART
Copy link
Contributor

@mothsART mothsART commented Mar 3, 2025

After using hachoir on modern xcf files, I found two issues :

  1. xcf => 4 used a header property, named "precision" who is document here https://testing.developer.gimp.org/core/standards/xcf/#header
  2. xcf >= 11 : offsets pointer (on layers, channels etc.) are write on 64 bits (instead of 32 before).

I've take care to keep compatibility on xcf older than version 4.

I don't claim to cover all cases but it's a good start.

You can fin my samples here : https://github.com/mothsART/xcf-rs/tree/master/tests/samples

@mothsART mothsART force-pushed the feature/evolution-xcf-11 branch from e43dcd1 to 80d7f08 Compare March 3, 2025 11:56
@vstinner
Copy link
Owner

vstinner commented Mar 3, 2025

Would it be possible to add a very small sample file and some tests? See tests/test_parser.py.

@mothsART
Copy link
Contributor Author

mothsART commented Mar 3, 2025

I've added 4 files : one for every major change. (and tests for each one).

@vstinner vstinner merged commit d6dc3d5 into vstinner:main Mar 4, 2025
2 checks passed
@vstinner
Copy link
Owner

vstinner commented Mar 4, 2025

Merged, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants