Update Readme to add components package release version matrix #307
Conversation
|
@ps37, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
=======================================
Coverage 88.68% 88.68%
=======================================
Files 93 93
Lines 2855 2855
Branches 437 437
=======================================
Hits 2532 2532
Misses 203 203
Partials 120 120 Continue to review full report at Codecov.
|
ps37
changed the title
…ponding to VCD app releases Add a table showing Components package versions corresponding to VMware cloud director(VCD) application releases Signed-off-by: ps37 <[email protected]>
ps37
force-pushed
the
update-readme-release-matrix
branch
from
0d50416 to
c3078a8
Compare
| [Angular CLI README](https://github.com/angular/angular-cli/blob/master/README.md). | ||
|
|
||
| ## Components package versions corresponding to VMware cloud director(VCD) application releases | ||
|
|
There was a problem hiding this comment.
Should we also put the version of Clarity we require? I know our package.json in components isn't perfectly up to date.
There was a problem hiding this comment.
We should and we should fix the package.json to have the correct dependencies
There was a problem hiding this comment.
Following are my thoughts:
- As our components use
Clarity, we should list@clr/packages in the peer dependencies list of our components project - We should then also fix the versions of
@angular/packages listed there. They should be updated to angular versions with which the above-listed Clarity version works - If we do the first thing above, I don't think we need to list
Clarityin the version matrix
Add a table showing Components package versions corresponding to VMware cloud director(VCD) application releases
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What does this change do?
Update readme to add a table showing Components package versions corresponding to VMware cloud director(VCD) application releases