[CI] Add pip and pre-commit caching to pre-commit workflow #32980
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
.github/workflows/pre-commit.yml
Outdated
| - uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3 | ||
| with: | ||
| path: ~/.cache/pre-commit | ||
| key: pre-commit-${{ runner.os }}-${{ hashFiles('.pre-commit-config.yaml') }} |
There was a problem hiding this comment.
Pre-commit cache key missing Python version
Low Severity
The pre-commit cache key pre-commit-${{ runner.os }}-${{ hashFiles('.pre-commit-config.yaml') }} doesn't include the Python version. Pre-commit creates Python-version-specific virtualenvs for each hook. If python-version is later changed from "3.12" to another version, the cached environments built for 3.12 could cause cryptic failures when hooks try to run with an incompatible interpreter.
Add caching for both pip packages and pre-commit hook environments to significantly reduce workflow execution time: - pip cache: reduces Python dependency installation time - pre-commit cache: avoids re-downloading hook repositories on each run Expected savings: ~30-60 seconds per workflow run on cache hits. Signed-off-by: 7. Sun <jhao.sun@gmail.com>
sjhddh
force-pushed
the
ci/cache-pre-commit
branch
from
f6284fb to
7917d8e
Compare
Signed-off-by: 7. Sun <jhao.sun@gmail.com>
1 participant
Summary
cache: 'pip'to speed up pip dependency installationactions/cachefor~/.cache/pre-committo cache pre-commit hook environments.pre-commit-config.yamlhash for proper invalidationTest Plan
Risk