Skip to content

middlware to track server load #18613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

daniel-salib
Copy link
Contributor

@daniel-salib daniel-salib commented May 23, 2025

an issue was found where load_aware_call could not handle timed out requests. Migrating to use middleware instead while keeping it behind the enable-server-load-tracking flag to avoid any potential performance impact.

with the middleware:
Serving Benchmark Result
Successful requests: 10000
Benchmark duration (s): 166.86
Total input tokens: 1000000
Total generated tokens: 1253399
Request throughput (req/s): 59.93
Output token throughput (tok/s): 7511.73
Total Token throughput (tok/s): 13504.82
---------------Time to First Token----------------
Mean TTFT (ms): 37.11
Median TTFT (ms): 26.30
P99 TTFT (ms): 219.72
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms): 13.06
Median TPOT (ms): 13.05
P99 TPOT (ms): 13.63
---------------Inter-token Latency----------------
Mean ITL (ms): 13.06
Median ITL (ms): 12.72
P99 ITL (ms): 18.98

without the middleware:
Serving Benchmark Result
Successful requests: 10000
Benchmark duration (s): 170.14
Total input tokens: 1000000
Total generated tokens: 1252755
Request throughput (req/s): 58.77
Output token throughput (tok/s): 7363.02
Total Token throughput (tok/s): 13240.48
---------------Time to First Token----------------
Mean TTFT (ms): 36.96
Median TTFT (ms): 27.08
P99 TTFT (ms): 291.95
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms): 13.33
Median TPOT (ms): 13.35
P99 TPOT (ms): 13.76
---------------Inter-token Latency----------------
Mean ITL (ms): 13.34
Median ITL (ms): 12.93
P99 ITL (ms): 20.07

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label May 23, 2025
@daniel-salib
Copy link
Contributor Author

@youngkent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant