-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[Build] Fixes for CMake install #18570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Build] Fixes for CMake install #18570
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: luka <[email protected]>
9a6959c
to
f6483ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just checking python setup.py build_ext --inplace
is not broken by this right?
I tried pip install, but let me try a fresh |
Please test fresh and incremental |
Yep, tested all three :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, will hold off till after the v0.9.0 release though to avoid anymore cmake thrash (bit of a battle recently haha)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these "cmake user workflows" actually documented somewhere?
No but they should be, I can try to add something. |
This fixes the CMake install logic such that using
cmake --install
directly is supported. Necessary to fix CMake-based user workflows.It also fixes the error on ROCm if CMake is used outside the venv (common for IDE-run CMake).