Skip to content

[Build] Fixes for CMake install #18570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ProExpertProg
Copy link
Contributor

@ProExpertProg ProExpertProg commented May 22, 2025

This fixes the CMake install logic such that using cmake --install directly is supported. Necessary to fix CMake-based user workflows.

It also fixes the error on ROCm if CMake is used outside the venv (common for IDE-run CMake).

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@ProExpertProg ProExpertProg changed the title Fixes for CMake install [Build] Fixes for CMake install May 22, 2025
@mergify mergify bot added the ci/build label May 22, 2025
@ProExpertProg ProExpertProg force-pushed the luka/cmake-install-fix branch from 9a6959c to f6483ae Compare May 22, 2025 21:02
Copy link
Collaborator

@LucasWilkinson LucasWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checking python setup.py build_ext --inplace is not broken by this right?

@ProExpertProg
Copy link
Contributor Author

just checking python setup.py build_ext --inplace is not broken by this right?

I tried pip install, but let me try a fresh python setup.py build_ext --inplace as well

@LucasWilkinson
Copy link
Collaborator

just checking python setup.py build_ext --inplace is not broken by this right?

I tried pip install, but let me try a fresh python setup.py build_ext --inplace as well

Please test fresh and incremental

@ProExpertProg
Copy link
Contributor Author

Yep, tested all three :)

Copy link
Collaborator

@LucasWilkinson LucasWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, will hold off till after the v0.9.0 release though to avoid anymore cmake thrash (bit of a battle recently haha)

@LucasWilkinson LucasWilkinson added the ready ONLY add when PR is ready to merge/full CI is needed label May 27, 2025
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these "cmake user workflows" actually documented somewhere?

@ProExpertProg
Copy link
Contributor Author

Are these "cmake user workflows" actually documented somewhere?

No but they should be, I can try to add something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants