Skip to content

feat(rocm-support): support mamba2 on rocm #18565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

almersawi
Copy link

@almersawi almersawi commented May 22, 2025

Supporting Mamba2 models in ROCm faces two issue:

  • XFormersMetadata and FlashAttentionMetadata are not available in ROCm, which raises this issue 13678
  • After fixing the first issue, the model is loaded to the GPU, but fails in the warmup with exception:
    AttributeError: '_OpNamespace' '_C' object has no attribute 'causal_conv1d_fwd'

@almersawi almersawi requested a review from tlrmchlsmth as a code owner May 22, 2025 20:10
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label May 22, 2025
Islam Almersawi added 8 commits May 24, 2025 10:57
…d selective_scan_fwd for rocm

Signed-off-by: Islam Almersawi <[email protected]>
Signed-off-by: Islam Almersawi <[email protected]>
…al_conv1d_fwd_launch function

Signed-off-by: Islam Almersawi <[email protected]>
@almersawi almersawi force-pushed the feat/rocm-mamba2-support branch from cb1f4da to 525e3ee Compare May 24, 2025 06:58
@almersawi almersawi changed the title feat(rocm-support): expose causal_conv1d_fwd, causal_conv1d_update and selective_scan_fwd for rocm feat(rocm-support): support mamba2 on rocm May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant